-
-
Notifications
You must be signed in to change notification settings - Fork 78.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an actual data-bs-touch="false"
example in the carousel docs
#32638
Conversation
this can also make it easier to actually check/debug any issues we may have with this data attribute
af2a6a2
to
e0fa28f
Compare
So it means the issue can not be reproduced in the main branch? (I can see that touch events are not working when |
correct, I edited/added this to the other issue about the supposed bug itself. still would like this as an addition to the docs regardless, as it makes it nice and obvious |
data-touch="false"
example in the carousel docsdata-bs-touch="false"
example in the carousel docs
26862d1
to
7608c04
Compare
looking at the code, it's still `ride`, not `slide`the `if "carousel"` bit was rather unclear/confusing
8bf3bee
to
8873ec9
Compare
e9c1d48
to
7ed36cc
Compare
</tr> | ||
<tr> | ||
<td><code>slide</code></td> | ||
<td><code>ride</code></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder why this was slide
all this time...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, either I missed something, or we've had a typo in the options all along...
(admittedly it's the first time I've properly looked at our carousels, but still)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it looks like it's a typo AFAICT. Going to merge this later.
…wbs#32638) * Add an actual `data-touch="false"` example in the carousel docs this can also make it easier to actually check/debug any issues we may have with this data attribute * Correct attribute table explanation and remove slide class from example
…32639) * v4: Add an actual `data-touch="false"` example in the carousel docs Backport of #32638 * Remove data-ride from example carousel * Correct attribute table explanation and remove slide class from example i believe the correct option is `slide` here, not `ride`. the `if "carousel"` bit was rather unclear/confusing * Edits... sorry, trying to make sense of our quirky carousel stuff, it seems some illogical things have been there ever since * Add data-interval to suppress autoplay * Tweak carousel options formatting * Update site/content/docs/4.5/components/carousel.md Co-authored-by: Mark Otto <markd.otto@gmail.com> * Tweak language mostly based on @mdo's suggestion, but also adds the word "attribute" after `data-ride` for better flow/legibility Co-authored-by: Mark Otto <markd.otto@gmail.com>
this can also make it easier to actually check/debug any issues we may have with this data attribute